Adds refresh to account section #3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
requested changes
Oct 3, 2024
package.json
Outdated
Comment on lines
8094
to
8099
| { | ||
| "command": "gitlens.views.home.account.refresh", | ||
| "title": "Refresh", | ||
| "category": "GitLens", | ||
| "icon": "$(refresh)" | ||
| }, |
There was a problem hiding this comment.
Unless a command needs to show up in VS Code controlled UI (command palette, menus) we don't need to register them here.
So in this case we can nuke this.
package.json
Outdated
Comment on lines
11491
to
11494
| { | ||
| "command": "gitlens.views.home.account.refresh", | ||
| "when": "false" | ||
| }, |
Comment on lines
222
to
228
| <gl-button | ||
| appearance="toolbar" | ||
| href="command:gitlens.views.home.account.refresh" | ||
| tooltip="Refresh" | ||
| aria-label="Refresh" | ||
| ><code-icon icon="refresh"></code-icon | ||
| ></gl-button> |
There was a problem hiding this comment.
Should we think of this as a "refresh" or a "re-sync"? @justinrobots
If "refresh" then this is good, but I'd change the tooltip to "Refresh Account Status"
If "re-sync" then maybe, use the sync icon and the tooltip to be "Synchronize Account Status"
There was a problem hiding this comment.
Sync does seem a little more concise and it would add a better distinction from the view's refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.